- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7
Extend azimuth angle range to [-180°, 180°] for PV inputs #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            danielfeismann
  merged 10 commits into
  dev
from
pp/#1330-increase-range-of-azimuth-angle-for-pv-inputs
  
      
      
   
  Jun 2, 2025 
      
    
                
     Merged
            
            Extend azimuth angle range to [-180°, 180°] for PV inputs #1334
                    danielfeismann
  merged 10 commits into
  dev
from
pp/#1330-increase-range-of-azimuth-angle-for-pv-inputs
  
      
      
   
  Jun 2, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    danielfeismann
  
              
              requested changes
              
                  
                    May 28, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little thing that needs adaption
        
          
                src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …th-angle-for-pv-inputs' into pp/#1330-increase-range-of-azimuth-angle-for-pv-inputs
              
                    danielfeismann
  
              
              approved these changes
              
                  
                    Jun 2, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Resolves #1330