-
Couldn't load subscription status.
- Fork 7
Adding validation for bdew load profile sources. #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding validation for bdew load profile sources. #1259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including some validation. Some minor suggestions from my side, take into account what makes sense to you.
I would be happy if we could add some test for the dynamisiation function of the H0 profile.
src/test/groovy/edu/ie3/resources/load/BdewLoadProfileTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/resources/load/BdewLoadProfileTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/resources/load/BdewLoadProfileTest.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including my points. Just two minor last things :)
src/test/groovy/edu/ie3/resources/load/BdewLoadProfileTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/resources/load/BdewLoadProfileTest.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for taking into account adding some validation!
Resolves #1243