Skip to content

Conversation

@staudtMarius
Copy link
Member

Resolves #1243

@staudtMarius staudtMarius added the enhancement New feature or request label Feb 25, 2025
@staudtMarius staudtMarius self-assigned this Feb 25, 2025
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including some validation. Some minor suggestions from my side, take into account what makes sense to you.

I would be happy if we could add some test for the dynamisiation function of the H0 profile.

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including my points. Just two minor last things :)

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for taking into account adding some validation!

@danielfeismann danielfeismann merged commit feee56c into dev Feb 26, 2025
3 checks passed
@danielfeismann danielfeismann deleted the ms/#1243-validation-of-bdew-load-profiles branch February 26, 2025 09:27
@sebastian-peter sebastian-peter added this to the Version 6.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation tests for load profiles

3 participants