add maximum ac and dc charging limits to evtype #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Add sRatedAC/DC in SystemParticipantTypeInputFactory.java -ReadTheDocs add sRatedAC/DC in ev.md -Changelog entry
|
I was in EVInput.java all day and not EVTypeInput.java |
-Maybe spelling mistakes corrected in EvTypeInput sRated Unit KW in KVA
-Updated ev_type_input.csv
-Updated ev_type_input.csv
-Updated ev_type_input.csv -Updated TypeTestData.groovy -Uptated InputEntityProcessorTest.groovy
-correct my mistakes kw=kva
…arging-limits-to-evtype' into pp/#876-add-maximum-ac-and-dc-charging-limits-to-evtype
danielfeismann
requested changes
Feb 8, 2024
There was a problem hiding this comment.
Thanks for working on this. This looks already quite well, but there is one thing we might not described well in the based issue. In my opinion existing sRated should be split into AC and DC. Thus sRated needs to be changed and only fields for DC added (or sRated needs to removed, AC and DC added instead).
src/main/java/edu/ie3/datamodel/io/factory/typeinput/SystemParticipantTypeInputFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/factory/typeinput/SystemParticipantTypeInputFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/system/type/EvTypeInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/system/type/EvTypeInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/system/type/EvTypeInput.java
Outdated
Show resolved
Hide resolved
danielfeismann
added
enhancement
Co-authored-by: Daniel Feismann <98817556+danielfeismann@users.noreply.github.com>
staudtMarius
previously requested changes
Feb 12, 2024
src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
Show resolved
Hide resolved
src/test/resources/edu/ie3/datamodel/io/source/csv/_types/ev_type_input.csv
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/system/type/EvTypeInput.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/system/type/EvTypeInput.java
Outdated
Show resolved
Hide resolved
…-to-evtype # Conflicts: # CHANGELOG.md
danielfeismann
requested changes
Feb 20, 2024
danielfeismann
approved these changes
Feb 21, 2024
danielfeismann
deleted the
pp/#876-add-maximum-ac-and-dc-charging-limits-to-evtype
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit DF: resolves #876
-Add sRatedAC/DC in EVTypeInput.java
-Add sRatedAC/DC in SystemParticipantTypeInputFactory.java
-ReadTheDocs add sRatedAC/DC in ev.md
-Changelog entry