Rethink column name determination in SQL source

[ckittl]

PowerSystemDataModel/src/main/java/edu/ie3/datamodel/io/source/sql/SqlDataSource.java

Lines 52 to 76 in be6b20b

	protected String getDbColumnName(String factoryColumnName, String tableName) {
	try {
	ResultSet rs =
	connector.getConnection().getMetaData().getColumns(null, null, tableName, null);
	while (rs.next()) {
	String databaseColumnName = rs.getString("COLUMN_NAME");
	if (StringUtils.snakeCaseToCamelCase(databaseColumnName)
	.equalsIgnoreCase(factoryColumnName)) {
	return databaseColumnName;
	}
	}
	} catch (SQLException ex) {
	log.error(
	"Cannot connect to database to retrieve db column name for factory column name '{}' in table '{}'",
	factoryColumnName,
	tableName,
	ex);
	}
	throw new InvalidColumnNameException(
	"Cannot find column for '"
	+ factoryColumnName
	+ "' in provided times series data configuration."
	+ "Please ensure that the database connection is working and the column names are correct!");
	}

The SQL sources use a method, that queries the given column names in a given table and tries to find a "match" based on a given "search string".

I feels like this method is a bit error prone and imperformant. Rethink, if this method really is useful or if we can switch over to fixed and defined column names.

[sebastian-peter]

This is somewhat related to #515.
Yes, we can think about this. Trade-off is the same as with csv sources, column names then have to be exact.

[sebastian-peter]

I think this is a great opportunity to introduce NamingConvention to all relevant sources.