Fix incorrect use of esc_html_e() in wp_die() calls #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests
Fixed Function in two files
🐛 Are you fixing a bug?
Yes
📝 Are you updating documentation?
💻 Are you changing functionality?
No
Template
Description of the Change
This pull request fixes incorrect usage of translation functions in two files. Specifically, several lines of code were using
esc_html_e()insidewp_die(), which is not appropriate sinceesc_html_e()echoes the translated string instead of returning it.The calls have been updated to use
esc_html__(), which correctly returns the translated string for use withinwp_die().Why This Change
wp_die().Verification Process
What process did you follow to verify that your change has the desired effects? Yes
Release Notes
Not applicable
Review
Pull Requests must have the sign-off of two other developers and at least one of these must be an IDX Broker team member.