Skip to content

Conversation

@DAnn2012
Copy link

Pull Requests

Fixed Function in two files

🐛 Are you fixing a bug?

Yes

📝 Are you updating documentation?

💻 Are you changing functionality?

No

Template

Description of the Change

This pull request fixes incorrect usage of translation functions in two files. Specifically, several lines of code were using esc_html_e() inside wp_die(), which is not appropriate since esc_html_e() echoes the translated string instead of returning it.
The calls have been updated to use esc_html__(), which correctly returns the translated string for use within wp_die().

Why This Change

  • Prevents unintended output when calling wp_die().
  • Ensures proper handling of translated strings.
  • Aligns with WordPress best practices for internationalization.

Verification Process

What process did you follow to verify that your change has the desired effects? Yes

  • How did you verify that all new functionality works as expected? Yes
  • How did you verify that all changed functionality works as expected? Yes
  • How did you verify that the change has not introduced any regressions? Yes

Release Notes

Not applicable

Review

Pull Requests must have the sign-off of two other developers and at least one of these must be an IDX Broker team member.

@DAnn2012
Copy link
Author

Hello @idxbrokerAdmin

When you can, could you take a look at this PR of mine?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant