[ error ] fix FC of errors in with-applications #3639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a few cases where the "With clause does not match parent" error points to the parent LHS instead of the
withapplication containing the error. The second code snippet in #3317 illustrates one case, where a parenthesis mismatch caused a function application to be interpreted as the first argument. Additional cases are forIAlternativeandIPrimVal. I've included a test case for each.The example from #3317:
Idris currently says:
and with this change, we get:
I've named the test case
idris2/error/withMatchesrather thanidris2/error/error034as the latter would conflict with another PR. Let me know if this is an issue.