Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding issue on Windows corresponded with fopen, popen and argv. #3644

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Fix encoding issue on Windows corresponded with fopen, popen and argv. #3644

merged 1 commit into from
Jan 31, 2017
+87 −15

Conversation

be5invis
Copy link
Contributor

No description provided.

@be5invis
Copy link
Contributor Author

cc. @melted

@melted
Copy link
Contributor

melted commented Jan 31, 2017

Thanks!

@melted melted merged commit d08fc3b into idris-lang:master Jan 31, 2017
@jfdm
Copy link
Contributor

jfdm commented Feb 3, 2017

Can a comment be added to the CHANGELOG detailing this fix.

Changess/fixes in encoding support on any platform, should be documented.

@be5invis
Copy link
Contributor Author

be5invis commented Feb 3, 2017

@jfdm
Changes are:

  • RTS function fileOpen and do_popen now can handle non-ASCII characters in its arguments.
  • argv are now correctly encoded in UTF-8 on Windows.

ahmadsalim pushed a commit that referenced this pull request Feb 3, 2017
Merge pull request #3649 from be5invis/be5inis-patch-changelog-3644
823d5d7 
Update changelog for #3644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@be5invis @melted @jfdm