Allow colored output on MinTTY consoles on Windows #3643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Idris REPL doesn't print colored output when you run it in a MinTTY console like Cygwin or MSYS:
This makes me sad.
The reason this happens is because due to a quirk in the way MinTTY, calling
isATTY
in it will always returnFalse
. But we shouldn't just useisATTY
to determine if we're in a console that supports colors! We can detect the presence of MinTTY pretty reliably by inspecting the file descriptor that MinTTY uses for its standard output. The minimalistmintty
library accomplishes this, so I've added a dependency on it.Now we can have colored output on MinTTY:
Yay!