Reduce redundancy across integer operations #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. In general, I think I prefer it if the common case (FInt here) remains a single name. Perhaps FInt could be a smart constructor instead. The tutorial would also need updating to explain what's going on here. |
…ed-int-primitives Conflicts: src/IRTS/CodegenC.hs src/IRTS/CodegenJava.hs
edwinb
added a commit
that referenced
this pull request
May 9, 2013
Reduce redundancy across integer operations
|
Sorry, I applied this but I've had to revert because it appears to break the tests. (I should have run them first but didn't!) Please can you check again that everything works fine then resend, with the output from 'make test' as a comment? It seems to be a problem with type providers but I don't have time to look into it at the moment. |
david-christiansen
added a commit
to david-christiansen/Idris-dev
that referenced
this pull request
May 9, 2013
…d-int-primitives"" This reverts commit 05895a5. This is to apply the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes reduce duplication of code for integer primitives both internally and in back ends.