Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove debounce else return #538

Merged
merged 2 commits into from
Jun 5, 2023
Merged

fix: remove debounce else return #538

merged 2 commits into from
Jun 5, 2023

Conversation

sadeghbarati
Copy link
Collaborator

@sadeghbarati sadeghbarati commented May 31, 2023 •
edited
Loading

Fixes #537

Description

IIRC refactoring debounce function, moving return to the else block was a mistake cause I think it block the autoHideOnIdle function call

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sadeghbarati sadeghbarati requested a review from idiotWu May 31, 2023 10:39
idiotWu
idiotWu requested changes Jun 5, 2023
View reviewed changes
src/utils/debounce.ts Outdated Show resolved Hide resolved
@idiotWu idiotWu merged commit cc67822 into develop Jun 5, 2023
@sadeghbarati sadeghbarati deleted the fix/debounce-auto-hide branch June 6, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idiotWu idiotWu idiotWu approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto hide doesn't work
2 participants
@sadeghbarati @idiotWu