Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting large numbers to text causes crash #240

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Converting large numbers to text causes crash #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixed large number conversion
  • Loading branch information
@lostways
lostways committed Dec 30, 2024
commit 4b147745c52ed36dd12fdf406c20d7c41b82613b
6 changes: 5 additions & 1 deletion TTS/tts/utils/text/english/number_norm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ def _expand_number(m):
if num % 100 == 0:
return _inflect.number_to_words(num // 100) + " hundred"
return _inflect.number_to_words(num, andword="", zero="oh", group=2).replace(", ", " ")
return _inflect.number_to_words(num, andword="")
try:
text = _inflect.number_to_words(num, andword="")
except inflect.NumOutOfRangeError:
text = _inflect.number_to_words(num, group=1).replace(", ", " ")
return text


def normalize_numbers(text):
Expand Down
2 changes: 2 additions & 0 deletions tests/text_tests/test_text_cleaners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ def test_currency() -> None:
def test_expand_numbers() -> None:
assert phoneme_cleaners("-1") == "minus one"
assert phoneme_cleaners("1") == "one"
assert phoneme_cleaners("1" + "0" * 35) == "one hundred decillion"
assert phoneme_cleaners("1" + "0" * 36) == "one" + " zero" * 36


def test_multilingual_phoneme_cleaners() -> None:
Expand Down
Loading