Filter for did document #105
Conversation
| AssertionMethod []Authentication `json:"assertionMethod,omitempty"` | ||
| Authentication []Authentication `json:"authentication,omitempty"` | ||
| KeyAgreement []interface{} `json:"keyAgreement,omitempty"` | ||
| KeyAgreement []Authentication `json:"keyAgreement,omitempty"` |
There was a problem hiding this comment.
backward compatibility has beed broken
There was a problem hiding this comment.
We should not break it, cast it where you need if you can
There was a problem hiding this comment.
We should not break it, cast it where you need if you can
There was a problem hiding this comment.
ok, break it. it wan't used
| AssertionMethod []Authentication `json:"assertionMethod,omitempty"` | ||
| Authentication []Authentication `json:"authentication,omitempty"` | ||
| KeyAgreement []interface{} `json:"keyAgreement,omitempty"` | ||
| KeyAgreement []Authentication `json:"keyAgreement,omitempty"` |
There was a problem hiding this comment.
ok, break it. it wan't used
verifiable/did_doc.go
Outdated
|
|
||
| func (d *DIDDocument) resolveToVM(items []Authentication) (CommonVerificationMethods, error) { | ||
| vms := make(CommonVerificationMethods, 0, len(items)) | ||
| for _, auth := range d.Authentication { |
There was a problem hiding this comment.
I think it should iterate over items, no?
There was a problem hiding this comment.
Thx a lot. Fixed
There was a problem hiding this comment.
Pull Request Overview
This pull request implements a draft filtering system for DID document verification methods. The implementation adds functionality to resolve, filter, and manage verification methods from DID documents.
- Adds verification method resolution for Authentication, AssertionMethod, and KeyAgreement sections
- Implements a filtering system with options for ID, Type, Controller, JWK Type, and JWK Algorithm
- Introduces a method to collect all verification methods from a DID document with deduplication
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| verifiable/did_doc.go | Core implementation of verification method resolution, filtering, and collection functionality |
| verifiable/did_doc_test.go | Comprehensive test suite covering all new functionality including edge cases and error scenarios |
| .golangci.yml | Updated linter configuration to use golangci-lint v2 format |
| .github/workflows/ci-test.yaml | Updated action versions for CI test workflow |
| .github/workflows/ci-lint.yaml | Modernized CI lint workflow to use golangci-lint action |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.