-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename
maxspeed
field type to roadspeed
Add `roadheight` field type for openstreetmap/iD#8075 Add `locationSet` info to the readme
- Loading branch information
1 parent
9518d0a
commit ef677f6
Showing
2 changed files
with
23 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef677f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
roadspeed
?maxspeed
is used on railway and waterway too..ef677f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, well this field type gets its units from the road signage used in the given country, which might not correspond to the units expected by other things. I changed the name since this field type is also used for
minspeed
.ef677f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, makes sense, I was just curious (no need to change anything)
ef677f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's one of those things where the name isn't incredibly important but since we're changing stuff anyone it seemed like a good opportunity to change it. I forgot about the railroad usage. I'm sure that eventually someone will complain about the default railway speed unit somewhere.