-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrying and limiting messages length when sending to teams #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmonterrubio
approved these changes
Oct 23, 2020
Closed
1 task
blalop
requested review from
caldito,
dortegau,
frantsao,
jperera,
sorobon,
Thasselhof,
vicsufer and
xtianae7
October 23, 2020 12:39
vicsufer
reviewed
Oct 25, 2020
Question time, how is this interacting when using multiple connectors?
|
Hi @vicsufer:
|
vicsufer
approved these changes
Oct 26, 2020
dortegau
approved these changes
Oct 26, 2020
caldito
approved these changes
Oct 26, 2020
dortegau
reviewed
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In the current state of prom2teams, there is nothing it can do to prevent missing Prometheus alerts due to several reasons, such as MS Teams being not available or prom2teams trying to send a payload that exceeds the limit MS Teams has.
Benefits
No alerts will be lost due to:
Possible Drawbacks
None
Applicable Issues
#223