Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use alert instead of alarm #155

Closed
1 task
dortegau opened this issue Oct 30, 2019 · 2 comments
Closed
1 task

Use alert instead of alarm #155

dortegau opened this issue Oct 30, 2019 · 2 comments
Assignees
@dortegau
Labels
good first issue

Comments

@dortegau
Copy link
Member

Prerequisites

Description

prom2teams is using this terms indistinctly because are synonyms. As Prometheus call it alerts, IMHO all "alarm" occurrences in code should be changed to "alert".
@stale
Copy link

stale bot commented Oct 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 18, 2020
@stale stale bot closed this as completed Oct 25, 2020
@dortegau dortegau reopened this Nov 3, 2020
@stale stale bot removed the wontfix label Nov 3, 2020
@dortegau dortegau self-assigned this Nov 3, 2020
dortegau added a commit that referenced this issue Nov 3, 2020
@dortegau
#155 using alert instead of alarm
242abb0
dortegau added a commit that referenced this issue Nov 3, 2020
@dortegau
#155 using alert instead of alarm
edf5b2a
@dortegau dortegau mentioned this issue Nov 3, 2020
Merged
dortegau added a commit that referenced this issue Nov 3, 2020
@dortegau
#155 Fixing small typo: coma -> comma
171796a
dortegau added a commit that referenced this issue Nov 4, 2020
@dortegau
Merge pull request #230 from idealista/features/155
500593c 
#155 using `alert` instead of `alarm`
@dortegau
Copy link
Member Author

dortegau commented Nov 4, 2020

merged!

@dortegau dortegau closed this as completed Nov 4, 2020
@vicsufer vicsufer mentioned this issue Nov 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dortegau dortegau

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dortegau