Update package.json #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've realised that the inclusion of the `@babel/plugin-transform-runtime` wasn't actually enough, there needs to also be a dependency on `@babel/runtime` itself. I've added this as a dependency on for the library itself rather than a peerDep. see https://babeljs.io/docs/en/babel-plugin-transform-runtime#technical-details for information on why
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 63.15% 63.15%
=======================================
Files 34 34
Lines 228 228
Branches 23 23
=======================================
Hits 144 144
Misses 76 76
Partials 8 8Continue to review full report at Codecov.
|
|
@samjt The build is failing. Can you try moving that to the |
|
I've updated to devdep and it's passing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've realised that the inclusion of the
@babel/plugin-transform-runtimewasn't actually enough, there needs to also be a dependency on@babel/runtimeitself. I've added this as a dependency on for the library itself rather than a peerDep as I understand that it's supposed to be non-polluting.I must have already had it installed from testing when I was proposing adding the plugin to .babelrc
See https://babeljs.io/docs/en/babel-plugin-transform-runtime#technical-details for information on why