[Task] adding a version control for excel file and the regression testing for a excel file #2283
Conversation
|
Thanks for the submission! The Python files contributed need to conform to the RAVEN style standard, which can be found here: https://github.com/idaholab/raven/wiki/RAVEN-Code-Standards |
…/raven into wenchi_issue_2278
1. Change the location of the python file (Excel_diff.py) to the ./Scripts 2.Copy the necessary path to the ".gitattributes" and "config" file and remove the .gitattributes under "D_01_Excel_Version_Control_Tool" 3. Tested the version control tool under raven git repository. 4. Change the format of the Excel_diff.py to meet the requirements
tests/reg_self_tests/D_02_Excel_Python_Regression_Testing_Tool/Excel_regression_testing.py
Outdated
Show resolved
Hide resolved
tests/reg_self_tests/D_02_Excel_Python_Regression_Testing_Tool/Excel_regression_testing.py
Outdated
Show resolved
Hide resolved
tests/reg_self_tests/D_02_Excel_Python_Regression_Testing_Tool/Excel_regression_testing.py
Outdated
Show resolved
Hide resolved
Address all the comments from Paul for "A few more minor changes". All the codes are tested before committing it through git.
Forgot to save the python file. This is the updated version after incorporating all the changes.
| @@ -0,0 +1,13 @@ | |||
| [Inputs] | |||
There was a problem hiding this comment.
This file seems to be in the base level of RAVEN, but should it be?
There was a problem hiding this comment.
I am okay based on Dylan's description of the diffing script's location, but I still believe this one is probably not in the right location.
There was a problem hiding this comment.
I removed this file and in the process of testing the best location on putting the outputs. I am thinking executing the diff through alias and put the output in the same folder but not sure if that will work for a custom diff.
| @@ -0,0 +1,62 @@ | |||
| import os | |||
There was a problem hiding this comment.
Should this be in raven/tests/scripts/TestHarness/testers?
There was a problem hiding this comment.
@PaulTalbot-INL since it's a general script for use outside of the testing harness, I instructed @wenchichenginl to put it in raven/scripts/ but let me know if you think it should only live within the testing harness.
|
Looking at the tests that run, it looks like most of the machines are skipping the excel test due to not having xlwings; do any of the machines have the library so that we test this? |
|
Job Mingw Test on df8d6db : invalidated by @PaulTalbot-INL Re-trying RAY internal parallel test |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#2278
What are the significant changes in functionality due to this change request?
Two python codes should be generated to deal with this issue. The first code is to diff the excel files and the second code is to test the excel if the formula is messed up.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.