Xfem 3d mesh cutter refactor and adding stress corrosion cracking #31615

lynnmunday · 2025-09-26T17:31:48Z

moosebuild · 2025-09-26T21:00:53Z

Job Documentation, step Docs: sync website on 9c4f14b wanted to post the following:

View the site here

This comment will be updated on new commits.

…rObject read fatigue values from this reporter. I think stress corrosion cracking can be created by parsed Reporter. ref idaholab#31615

moosebuild · 2025-10-01T22:54:45Z

Job Precheck, step Clang format on a70c9b5 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/31615/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 23927d0dc7a66eccf59bbb36953ba4c8ff321a01

…rObject read fatigue values from this reporter. I think stress corrosion cracking can be created by parsed Reporter. ref idaholab#31615

moosebuild · 2025-10-02T20:38:27Z

Job Coverage, step Generate coverage on 9c4f14b wanted to post the following:

Framework coverage

	236997	#31615 9c4f14
	Total	Total	+/-	New
Rate	85.93%	85.93%	-0.00%	-
Hits	122919	122918	-1	0
Misses	20122	20123	+1	0

Diff coverage report

Full coverage report

Modules coverage

Xfem

	236997	#31615 9c4f14
	Total	Total	+/-	New
Rate	82.56%	82.62%	+0.07%	100.00%
Hits	7057	7133	+76	174
Misses	1491	1500	+9	0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

lindsayad · 2025-10-02T21:08:50Z

#31621 is a prereq for this. @lynnmunday please bring out of draft once that PR is merged

…as the 2D mesh. Also adding verbosity to some error messages. Cleaning up some other stuff not used. Getting vectorpostprocessors in constructor and adding a param to get them by name.

…rObject read fatigue values from this reporter. I think stress corrosion cracking can be created by parsed Reporter. ref idaholab#31615

builds and tests pass

…chanics part and then seperate files for the mesh cutter part.

…th reporter values.

removing test.i as its not used by anything

…ning ki and kii values

moosebuild · 2025-10-06T23:11:56Z

Job Python 3.13 (Apptainer) on c4a6907 : invalidated by @lynnmunday

moosebuild · 2025-10-06T23:12:32Z

Job CUDA GPU on c4a6907 : invalidated by @lynnmunday

moosebuild · 2025-10-07T14:57:00Z

Job Python 3.13 (Apptainer) on c4a6907 : invalidated by @lynnmunday

moosebuild · 2025-10-07T17:17:27Z

Job Python 3.13 (Apptainer) on c4a6907 : invalidated by @lynnmunday

lynnmunday · 2025-10-09T20:09:03Z

@bwspenc Will you review? The broken test is not from this.

lynnmunday · 2025-10-09T22:04:42Z

@codex

lynnmunday · 2025-10-09T22:13:58Z

@codex
Are you reviewing my code?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

chatgpt-codex-connector · 2025-10-09T22:19:16Z

modules/xfem/src/reporters/StressCorrosionCracking.C

+  Real max_growth_rate = *std::max_element(growth_rate.begin(), growth_rate.end());
+  _corrosion_time_step = _max_growth_size / max_growth_rate;


Guard against zero growth rate in SCC reporter

When every entry in growth_rate stays at zero (for example when the user supplies growth_rate_low = growth_rate_high = 0 or there are no active crack-front nodes), max_growth_rate evaluates to 0 and _corrosion_time_step divides by zero. This produces inf/NaN values in _growth_increment, which will be consumed by the mesh cutter and can corrupt node coordinates. Consider short‑circuiting when the maximum rate is non‑positive and leaving the increments at zero instead of computing a ratio.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2025-10-09T22:19:17Z

modules/xfem/src/reporters/ParisLaw.C

+  Real _max_k = *std::max_element(effective_k.begin(), effective_k.end());
+  _dn = _max_growth_size / (_paris_law_c * std::pow(_max_k, _paris_law_m));
+
+  for (std::size_t i = 0; i < _ki_vpp.size(); ++i)
+    if (index[i] != -1)
+      _growth_increment[i] = _max_growth_size * std::pow(effective_k[i] / _max_k, _paris_law_m);


ParisLaw reports NaNs when fracture integrals are zero

If all KI/KII values are zero for a step, effective_k remains zeros so _max_k becomes 0. The subsequent division _max_growth_size / (_paris_law_c * pow(_max_k, _paris_law_m)) and normalization of effective_k[i] / _max_k therefore divide by zero, yielding infinite or NaN cycle counts and growth increments. This can occur on initial timesteps before loads are applied. A guard for _max_k <= 0 that returns zero growth (and zero cycles) would avoid generating invalid numbers.

Useful? React with 👍 / 👎.

lynnmunday requested review from bwspenc and jiangwen84 as code owners September 26, 2025 17:31

lynnmunday force-pushed the xfem3Dcutter branch 2 times, most recently from 300d96c to 5c64b34 Compare September 26, 2025 18:44

lynnmunday force-pushed the xfem3Dcutter branch from 5c64b34 to bd9cf11 Compare September 26, 2025 21:08

lynnmunday force-pushed the xfem3Dcutter branch from bd9cf11 to 61e2587 Compare September 26, 2025 21:25

lynnmunday force-pushed the xfem3Dcutter branch from 61e2587 to f1e28c9 Compare September 26, 2025 21:27

lynnmunday force-pushed the xfem3Dcutter branch from f1e28c9 to b51ba90 Compare September 26, 2025 22:44

GiudGiud assigned bwspenc Sep 28, 2025

lynnmunday force-pushed the xfem3Dcutter branch from b51ba90 to a70c9b5 Compare October 1, 2025 22:47

lynnmunday requested review from dschwen, lindsayad, loganharbour and zachmprince as code owners October 1, 2025 22:47

lynnmunday force-pushed the xfem3Dcutter branch from a70c9b5 to 1367305 Compare October 2, 2025 15:27

lindsayad marked this pull request as draft October 2, 2025 21:08

lynnmunday force-pushed the xfem3Dcutter branch from 1367305 to 09954de Compare October 2, 2025 21:53

lindsayad marked this pull request as ready for review October 3, 2025 16:01

lynnmunday added 2 commits October 6, 2025 10:48

fixing issue so the execution group for the 3D mesh will be the same …

ec862db

…as the 2D mesh. Also adding verbosity to some error messages. Cleaning up some other stuff not used. Getting vectorpostprocessors in constructor and adding a param to get them by name.

vector postprocessor computing paris law growth parameters

00c8662

lynnmunday added 10 commits October 6, 2025 10:48

Moved the paris law into a reporter and changed the CrackmeshCut3DUse…

b09640d

…rObject read fatigue values from this reporter. I think stress corrosion cracking can be created by parsed Reporter. ref idaholab#31615

adding scc reporter reading to 3D crack cutter.

2121844

builds and tests pass

sorting out indexing in vector postprocessors and 3D meshcutter

c0c5130

combined mesh cutter tests into a common file they all use for the me…

1c7141f

…chanics part and then seperate files for the mesh cutter part.

getting rid of seperate options for fatigue and scc since they are bo…

95675dc

…th reporter values.

example with scc function. needs gold file but json look right

da322e0

reporter for computing scc

9fa7dfb

including tests of scc crack growth

fd6d93f

removing test.i as its not used by anything

fixing sorting of reporters to be in the same order as the vpp contai…

1f78075

…ning ki and kii values

adding base class for common subcritical crack growth functions

7f31423

lynnmunday force-pushed the xfem3Dcutter branch 2 times, most recently from 49f5e08 to e210254 Compare October 6, 2025 19:06

Adding documentation for stress corrosion cracking

c4a6907

lynnmunday force-pushed the xfem3Dcutter branch from e210254 to c4a6907 Compare October 6, 2025 21:07

chatgpt-codex-connector bot reviewed Oct 9, 2025

View reviewed changes

addressing chatgpt review comments

9c4f14b

		Real max_growth_rate = *std::max_element(growth_rate.begin(), growth_rate.end());
		_corrosion_time_step = _max_growth_size / max_growth_rate;

Xfem 3d mesh cutter refactor and adding stress corrosion cracking #31615

Are you sure you want to change the base?

Xfem 3d mesh cutter refactor and adding stress corrosion cracking #31615

Conversation

lynnmunday commented Sep 26, 2025

Uh oh!

moosebuild commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moosebuild commented Oct 1, 2025

Uh oh!

moosebuild commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Framework coverage

Modules coverage

Xfem

Full coverage reports

Uh oh!

lindsayad commented Oct 2, 2025

Uh oh!

moosebuild commented Oct 6, 2025

Uh oh!

moosebuild commented Oct 6, 2025

Uh oh!

moosebuild commented Oct 7, 2025

Uh oh!

moosebuild commented Oct 7, 2025

Uh oh!

lynnmunday commented Oct 9, 2025

Uh oh!

lynnmunday commented Oct 9, 2025

Uh oh!

lynnmunday commented Oct 9, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

moosebuild commented Sep 26, 2025 •

edited

Loading

moosebuild commented Oct 2, 2025 •

edited

Loading