Feature: Set cell.fill.universes with an array of IDs #815

digvijay-y · 2025-10-05T05:27:57Z

Pull Request Checklist for MontePy

Description

Allowed setting cell.fill.universes with array of universe IDs which are resolved by universeObjects.

Includes a dedicated test file.

Fixes #736

General Checklist

I have performed a self-review of my own code.
The code follows the standards outlined in the development documentation.
I have formatted my code with black version 25.
I have added tests that prove my fix is effective or that my feature works (if applicable).

Documentation Checklist

I have documented all added classes and methods.
For infrastructure updates, I have updated the developer's guide.
For significant new features, I have added a section to the getting started guide.

First-Time Contributor Checklist

If this is your first contribution, add yourself to pyproject.toml if you wish to do so.

Additional Notes for Reviewers

Ensure that:

The submitted code is consistent with the merge checklist outlined here.
The PR covers all relevant aspects according to the development guidelines.
100% coverage of the patch is achieved, or justification for a variance is given.

📚 Documentation preview 📚: https://montepy--815.org.readthedocs.build/en/815/

Bumps [sigstore/gh-action-sigstore-python](https://github.com/sigstore/gh-action-sigstore-python) from 047e8aa38a2a125cc0bf1332cfb9b53f9fdc0733 to 15ce42889ff1d65509841d7c63480f64affe3a64. - [Release notes](https://github.com/sigstore/gh-action-sigstore-python/releases) - [Changelog](https://github.com/sigstore/gh-action-sigstore-python/blob/main/CHANGELOG.md) - [Commits](sigstore/gh-action-sigstore-python@047e8aa...15ce428) --- updated-dependencies: - dependency-name: sigstore/gh-action-sigstore-python dependency-version: 15ce42889ff1d65509841d7c63480f64affe3a64 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

…ore/gh-action-sigstore-python-15ce42889ff1d65509841d7c63480f64affe3a64 Bump sigstore/gh-action-sigstore-python from 047e8aa38a2a125cc0bf1332cfb9b53f9fdc0733 to 15ce42889ff1d65509841d7c63480f64affe3a64

Bumps [sigstore/gh-action-sigstore-python](https://github.com/sigstore/gh-action-sigstore-python) from 15ce42889ff1d65509841d7c63480f64affe3a64 to 3de1a2a3c264daaa39b533c979f3793e0ddca0f8. - [Release notes](https://github.com/sigstore/gh-action-sigstore-python/releases) - [Changelog](https://github.com/sigstore/gh-action-sigstore-python/blob/main/CHANGELOG.md) - [Commits](sigstore/gh-action-sigstore-python@15ce428...3de1a2a) --- updated-dependencies: - dependency-name: sigstore/gh-action-sigstore-python dependency-version: 3de1a2a3c264daaa39b533c979f3793e0ddca0f8 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…ore/gh-action-sigstore-python-3de1a2a3c264daaa39b533c979f3793e0ddca0f8 Bump sigstore/gh-action-sigstore-python from 15ce42889ff1d65509841d7c63480f64affe3a64 to 3de1a2a3c264daaa39b533c979f3793e0ddca0f8

…d-artifact-5

…ns/download-artifact-5 Bump actions/download-artifact from 4 to 5

Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…ns/checkout-5 Bump actions/checkout from 4 to 5

…ong-a-line-is Fix bug with over-agressive LineOverRunWarning

Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.12.4 to 1.13.0. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@76f52bc...ed0c539) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-version: 1.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…gh-action-pypi-publish-1.13.0 Bump pypa/gh-action-pypi-publish from 1.12.4 to 1.13.0

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…ns/setup-python-6 Bump actions/setup-python from 5 to 6

Bumps [ncipollo/release-action](https://github.com/ncipollo/release-action) from 1.18.0 to 1.20.0. - [Release notes](https://github.com/ncipollo/release-action/releases) - [Commits](ncipollo/release-action@bcfe547...b7eabc9) --- updated-dependencies: - dependency-name: ncipollo/release-action dependency-version: 1.20.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…llo/release-action-1.20.0 Bump ncipollo/release-action from 1.18.0 to 1.20.0

Bumps [sigstore/gh-action-sigstore-python](https://github.com/sigstore/gh-action-sigstore-python) from 3de1a2a3c264daaa39b533c979f3793e0ddca0f8 to f909491f27c345faa936da468c9ddfac57cbeb49. - [Release notes](https://github.com/sigstore/gh-action-sigstore-python/releases) - [Changelog](https://github.com/sigstore/gh-action-sigstore-python/blob/main/CHANGELOG.md) - [Commits](sigstore/gh-action-sigstore-python@3de1a2a...f909491) --- updated-dependencies: - dependency-name: sigstore/gh-action-sigstore-python dependency-version: f909491f27c345faa936da468c9ddfac57cbeb49 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

…ore/gh-action-sigstore-python-f909491f27c345faa936da468c9ddfac57cbeb49 Bump sigstore/gh-action-sigstore-python from 3de1a2a3c264daaa39b533c979f3793e0ddca0f8 to f909491f27c345faa936da468c9ddfac57cbeb49

digvijay-y · 2025-10-06T08:18:06Z

Thanks @MicahGale for provoding examples and mentioning relevent manual sections, it got easy! Had to spend time on Example sections!

digvijay-y · 2025-10-06T08:24:33Z

By the way, i found that test_nuclide.py has 1 failed case!

FAILED tests/test_nuclide.py::TestNucleus::test_nucleus_init_eq_hash - AssertionError: assert Nucleus(berkelium, 285, 1) == Nucleus(berkelium, 185, 2)

MicahGale

Just a few final changes.

doc/source/conf.py

montepy/data_inputs/fill.py

MicahGale · 2025-10-06T13:55:11Z

By the way, i found that test_nuclide.py has 1 failed case!

FAILED tests/test_nuclide.py::TestNucleus::test_nucleus_init_eq_hash - AssertionError: assert Nucleus(berkelium, 285, 1) == Nucleus(berkelium, 185, 2)

Yes this is a test failure that randomly shows up as the hypothesis test suite finds nuclides that don't exist and break our nuclide parsing system. You can safely ignore this for now; I'll finally open an issue for this.

wrote LLM disclosure in PR template.

Full test suite re-org

MicahGale

Just a few more tweaks.

montepy/data_inputs/fill.py

MicahGale · 2025-10-09T13:06:32Z

I moved this to minor-rel-dev because this is a minor release, I'm trying out have two staging branches.

MicahGale

LGTM. Thanks again @digvijay-y!

dependabot bot and others added 30 commits August 4, 2025 02:11

Merge pull request #789 from idaholab/dependabot/github_actions/sigst…

536dd60

…ore/gh-action-sigstore-python-15ce42889ff1d65509841d7c63480f64affe3a64 Bump sigstore/gh-action-sigstore-python from 047e8aa38a2a125cc0bf1332cfb9b53f9fdc0733 to 15ce42889ff1d65509841d7c63480f64affe3a64

Merge pull request #791 from idaholab/dependabot/github_actions/sigst…

3b42b88

…ore/gh-action-sigstore-python-3de1a2a3c264daaa39b533c979f3793e0ddca0f8 Bump sigstore/gh-action-sigstore-python from 15ce42889ff1d65509841d7c63480f64affe3a64 to 3de1a2a3c264daaa39b533c979f3793e0ddca0f8

Merge branch 'develop' into dependabot/github_actions/actions/downloa…

5194e5c

…d-artifact-5

Merge pull request #792 from idaholab/dependabot/github_actions/actio…

888341a

…ns/download-artifact-5 Bump actions/download-artifact from 4 to 5

Merge pull request #795 from idaholab/dependabot/github_actions/actio…

da31295

…ns/checkout-5 Bump actions/checkout from 4 to 5

Updated input to have valid non space input right up to the 6.2 limit.

2377e40

Updated line expansion to ignore whitespace and allow up to the limit.

1ab4095

Added #517 to changelog.

c67e0fe

Merge pull request #799 from idaholab/517-montepy-cant-agree-on-how-l…

727aa0c

…ong-a-line-is Fix bug with over-agressive LineOverRunWarning

Merge pull request #806 from idaholab/dependabot/github_actions/pypa/…

ae894e3

…gh-action-pypi-publish-1.13.0 Bump pypa/gh-action-pypi-publish from 1.12.4 to 1.13.0

Merge pull request #805 from idaholab/dependabot/github_actions/actio…

4d1cc48

…ns/setup-python-6 Bump actions/setup-python from 5 to 6

Merge pull request #804 from idaholab/dependabot/github_actions/ncipo…

561d793

…llo/release-action-1.20.0 Bump ncipollo/release-action from 1.18.0 to 1.20.0

Merge pull request #811 from idaholab/dependabot/github_actions/sigst…

3d190b7

…ore/gh-action-sigstore-python-f909491f27c345faa936da468c9ddfac57cbeb49 Bump sigstore/gh-action-sigstore-python from 3de1a2a3c264daaa39b533c979f3793e0ddca0f8 to f909491f27c345faa936da468c9ddfac57cbeb49

Filled excpetion messages for TypeError raises.

6a76718

Updated pyproject.toml

c1fb980

missing comma

8125348

Changelog updated! and changed files formatted!

51e1321

maintained consistency in TypeError messages across the codebase

fa5cf61

wrote LLM disclosure in PR template.

877fd75

Converted unittest to pytest using Copilot.

dcec956

Converted more test files fully to pytest with copilot.

2b2057d

Finished converting all tests over to pytest with copilot.

4d42077

digvijay-y added 7 commits October 6, 2025 07:34

imported modules

f9a1994

updated fill.py

101d02b

doc_test

3af1df4

fix: failing doc-test

77c0c5f

black universe.py

509293f

doc-test

42ac8bd

modified: montepy/universe.py

7ea8f94

digvijay-y requested a review from MicahGale October 6, 2025 08:25

MicahGale requested changes Oct 6, 2025

View reviewed changes

MicahGale mentioned this pull request Oct 6, 2025

Hypothesis creates non-existant breaking nuclides #818

Closed

MicahGale and others added 5 commits October 6, 2025 11:56

Merge branch 'develop' into llm_pr

3e5785f

Merge pull request #813 from idaholab/llm_pr

6ef89ad

wrote LLM disclosure in PR template.

Merge branch 'develop' into full_pytest

e33c3dd

Merge pull request #814 from idaholab/full_pytest

92a6fb1

Full test suite re-org

Final changes

9925cb1

digvijay-y requested a review from MicahGale October 6, 2025 18:12

Merge branch 'develop' into setting_universe

b8ad802

MicahGale requested changes Oct 6, 2025

View reviewed changes

montepy/data_inputs/fill.py Outdated Show resolved Hide resolved

montepy/data_inputs/fill.py Outdated Show resolved Hide resolved

Modified fill.py

5536fc3

digvijay-y requested a review from MicahGale October 7, 2025 12:45

MicahGale changed the base branch from develop to minor-rel-dev October 9, 2025 13:02

Merge branch 'minor-rel-dev' into setting_universe

ad15d13

MicahGale approved these changes Oct 9, 2025

View reviewed changes

MicahGale merged commit 9ac2814 into idaholab:minor-rel-dev Oct 9, 2025
18 checks passed

digvijay-y deleted the setting_universe branch October 10, 2025 09:22

MicahGale mentioned this pull request Oct 14, 2025

Stage release 1.2.0 #823

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Set cell.fill.universes with an array of IDs #815

Feature: Set cell.fill.universes with an array of IDs #815

Uh oh!

digvijay-y commented Oct 5, 2025 •

edited by MicahGale

Loading

Uh oh!

digvijay-y commented Oct 6, 2025

Uh oh!

digvijay-y commented Oct 6, 2025

Uh oh!

MicahGale left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MicahGale commented Oct 6, 2025

Uh oh!

MicahGale left a comment

Uh oh!

Uh oh!

Uh oh!

MicahGale commented Oct 9, 2025

Uh oh!

MicahGale left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Feature: Set cell.fill.universes with an array of IDs #815

Feature: Set cell.fill.universes with an array of IDs #815

Uh oh!

Conversation

digvijay-y commented Oct 5, 2025 • edited by MicahGale Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist for MontePy

Description

General Checklist

Documentation Checklist

First-Time Contributor Checklist

Additional Notes for Reviewers

Uh oh!

digvijay-y commented Oct 6, 2025

Uh oh!

digvijay-y commented Oct 6, 2025

Uh oh!

MicahGale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MicahGale commented Oct 6, 2025

Uh oh!

MicahGale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MicahGale commented Oct 9, 2025

Uh oh!

MicahGale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

digvijay-y commented Oct 5, 2025 •

edited by MicahGale

Loading