Skip to content

Conversation

@MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Jul 2, 2025

Pull Request Checklist for MontePy

Description

This resolves #584, a parsing error with FQ inputs. This seems to have been resolved in a previous bug fix, so I am just adding FQ to the test suite to act as a regression test.

I think we can override the changelog test for this, as I don't think this merits a changelog entry.

Fixes #584.

General Checklist

  • I have performed a self-review of my own code.
  • The code follows the standards outlined in the development documentation.
  • I have added tests that prove my fix is effective or that my feature works (if applicable).

Additional Notes for Reviewers

Ensure that:

  • The submitted code is consistent with the merge checklist outlined here.
  • The PR covers all relevant aspects according to the development guidelines.
  • 100% coverage of the patch is achieved, or justification for a variance is given.

📚 Documentation preview 📚: https://montepy--772.org.readthedocs.build/en/772/

@MicahGale MicahGale requested a review from tjlaboss July 2, 2025 14:07
@MicahGale MicahGale self-assigned this Jul 2, 2025
@MicahGale MicahGale added the code improvement A feature request that will improve the software and its maintainability, but be invisible to users. label Jul 2, 2025
@MicahGale MicahGale linked an issue Jul 2, 2025 that may be closed by this pull request
Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I have to say is that the changelog test auto-passes because this change does not touch the source directory.

@MicahGale MicahGale merged commit 71665ad into develop Jul 2, 2025
25 checks passed
@MicahGale MicahGale deleted the 584-fail-to-parse-fq-cards branch July 2, 2025 21:41
@MicahGale MicahGale mentioned this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code improvement A feature request that will improve the software and its maintainability, but be invisible to users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to parse FQ cards

2 participants