Skip to content

Conversation

@MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Mar 25, 2025

Pull Request Checklist for MontePy

Description

This fixes a "bug" where setting Fill.universes was not properly exported. There was previously... an effort to implement this, which was not successful. This changed:

  1. Making sure min_index and max_index is always accessible without crashing
  2. Setting min_index and max_index whenever universes is set.
  3. setting mulitple_universes=True whenever universes is set.
  4. _update_cell_values works properly.

Fixes #714


General Checklist

  • I have performed a self-review of my own code.
  • The code follows the standards outlined in the development documentation.
  • I have formatted my code with black version 25.
  • I have added tests that prove my fix is effective or that my feature works (if applicable).

Documentation Checklist

  • I have documented all added classes and methods.
  • For infrastructure updates, I have updated the developer's guide.
  • For significant new features, I have added a section to the getting started guide.

First-Time Contributor Checklist

  • If this is your first contribution, add yourself to pyproject.toml if you wish to do so.

Additional Notes for Reviewers

Ensure that:

  • The submitted code is consistent with the merge checklist outlined here.
  • The PR covers all relevant aspects according to the development guidelines.
  • 100% coverage of the patch is achieved, or justification for a variance is given.

📚 Documentation preview 📚: https://montepy--717.org.readthedocs.build/en/717/

@MicahGale MicahGale added alpha testing Issues that came up during alpha testing bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". labels Mar 25, 2025
@MicahGale MicahGale self-assigned this Mar 25, 2025
@MicahGale MicahGale linked an issue Mar 25, 2025 that may be closed by this pull request
@MicahGale MicahGale changed the base branch from develop to alpha-test-dev March 26, 2025 02:49
@MicahGale MicahGale requested a review from tjlaboss March 26, 2025 02:50
@MicahGale MicahGale marked this pull request as ready for review March 26, 2025 03:00
@MicahGale MicahGale merged commit 26cf851 into alpha-test-dev Mar 28, 2025
24 checks passed
@MicahGale MicahGale deleted the 714-multi-universe-fill-cant-be-created-from-scratch branch March 28, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alpha testing Issues that came up during alpha testing bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error".

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-Universe fill can't be created from scratch

2 participants