Fixed surfaces cant be unset from is reflecting

[MicahGale]

Pull Request Checklist for MontePy

Description

This is a quick fix for the case where is_reflecting=False did nothing on output. This is because the syntax tree was only updated iff is_reflecting ^ is_white_boundary is True. This was a quick fix by giving a final else.

You know in rust had I done something like:

match (self.is_reflecting, self.is_white_boundary) {
   (True, False) => ...,
   (False, True) => ...,
}

The compiler would have complained. (Ignore the fact it would have been happy with:

if self.is_reflecting {

else if self.is_white_boundary {

}

)

Update

• this causes an issue with a continue line if you have four leading spaces: *1... becomes 1.... This is because even with never_pad the minimum value length of the node is passed to the string formatter. This was solved by:

1. Avoiding value_length for never_pad
2. fixing method where modifier node is retroactively created for +1 numbers where never_pad=False
3. Giving never_pad argumentto_generate_default_node`

Fixes #709

Also before you look a few lines down in the code see #711.

General Checklist

• I have performed a self-review of my own code.
• The code follows the standards outlined in the development documentation.
• I have formatted my code with black version 25.
• I have added tests that prove my fix is effective or that my feature works (if applicable).

---

Documentation Checklist

• I have documented all added classes and methods.
• For infrastructure updates, I have updated the developer's guide.
• For significant new features, I have added a section to the getting started guide.

---

First-Time Contributor Checklist

• If this is your first contribution, add yourself to pyproject.toml if you wish to do so.

---

Additional Notes for Reviewers

Ensure that:

• The submitted code is consistent with the merge checklist outlined here.
• The PR covers all relevant aspects according to the development guidelines.
• 100% coverage of the patch is achieved, or justification for a variance is given.

---

📚 Documentation preview 📚: https://montepy--710.org.readthedocs.build/en/710/

[MicahGale]

The new output looks like 101 PZ -0.63. I don't like that new leading space, but it's not incorrect, so I'm thinking let's hold off for now.

[tjlaboss]

That sounds fine: it preserves the transformed surface card's alignment.

I will test a case where the line contains 4 leading space to verify that this doesn't incorrectly change it into a continuation line.

[tjlaboss]

As it turns out, disabling is_reflecting or is_white_boundary on a line with 4 leading spaces does give it a fifth.

[MicahGale]

As it turns out, disabling is_reflecting or is_white_boundary on a line with 4 leading spaces does give it a fifth.

So question do we:

1. preserve formatting, but then handle edge case of too much padding?
2. Just always shrink to the left?

the second seems a lot easier.

[tjlaboss]

Priority 1 (make it right) is higher than priority 4 (make it pretty). So do option 2, and if if it's ugly, turn that into a separate issue.