-
Notifications
You must be signed in to change notification settings - Fork 18
Fixing syntax error with updating is_reflecting #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MicahGale
merged 8 commits into
alpha-test-dev
from
697-setting-a-surface-as-reflecting-creates-invalid-syntax
Mar 18, 2025
Merged
Fixing syntax error with updating is_reflecting #698
MicahGale
merged 8 commits into
alpha-test-dev
from
697-setting-a-surface-as-reflecting-creates-invalid-syntax
Mar 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjlaboss
reviewed
Mar 17, 2025
Collaborator
tjlaboss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. One suggestion for simplicity. Copyright lines might have been overlooked?
tjlaboss
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugs
A deviation from expected behavior that does not reach the level of being reportable as an "Error".
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist for MontePy
Description
This fixes a bug where setting
surf.is_reflecting = Truewould output* 1 PZ 0.0. This was simply fixed by marking the modifier node asnever_padwhich tells it to not add space after this node.Fixes #697
General Checklist
blackversion 25.Documentation Checklist
First-Time Contributor Checklist
pyproject.tomlif you wish to do so.Additional Notes for Reviewers
Ensure that:
📚 Documentation preview 📚: https://montepy--698.org.readthedocs.build/en/698/