Skip to content

Conversation

@MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Mar 16, 2025

Pull Request Checklist for MontePy

Description

This fixes a bug where setting surf.is_reflecting = True would output * 1 PZ 0.0. This was simply fixed by marking the modifier node as never_pad which tells it to not add space after this node.

Fixes #697


General Checklist

  • I have performed a self-review of my own code.
  • The code follows the standards outlined in the development documentation.
  • I have formatted my code with black version 25.
  • I have added tests that prove my fix is effective or that my feature works (if applicable).

Documentation Checklist


First-Time Contributor Checklist

  • If this is your first contribution, add yourself to pyproject.toml if you wish to do so.

Additional Notes for Reviewers

Ensure that:

  • The submitted code is consistent with the merge checklist outlined here.
  • The PR covers all relevant aspects according to the development guidelines.
  • 100% coverage of the patch is achieved, or justification for a variance is given.

📚 Documentation preview 📚: https://montepy--698.org.readthedocs.build/en/698/

@MicahGale MicahGale linked an issue Mar 16, 2025 that may be closed by this pull request
@MicahGale MicahGale changed the base branch from develop to alpha-test-dev March 16, 2025 18:13
@MicahGale MicahGale marked this pull request as ready for review March 16, 2025 18:13
@MicahGale MicahGale requested a review from tjlaboss March 16, 2025 18:13
@MicahGale MicahGale self-assigned this Mar 16, 2025
@MicahGale MicahGale added the bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". label Mar 16, 2025
@MicahGale MicahGale added this to the M&C workshop milestone Mar 16, 2025
@MicahGale MicahGale enabled auto-merge March 17, 2025 21:53
Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. One suggestion for simplicity. Copyright lines might have been overlooked?

@MicahGale MicahGale requested a review from tjlaboss March 18, 2025 00:01
@MicahGale MicahGale merged commit 144edf7 into alpha-test-dev Mar 18, 2025
24 checks passed
@MicahGale MicahGale deleted the 697-setting-a-surface-as-reflecting-creates-invalid-syntax branch March 18, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error".

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting a surface as reflecting creates invalid syntax

2 participants