-
Notifications
You must be signed in to change notification settings - Fork 18
Added tutorials for new material API. #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tjlaboss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to mess around with the alpha test branch with fresh eyes to see if the new documentation makes sense, but here are some initial things to address.
I'll push a commit to this branch with some punctuation changes too
|
Nucleardata.lanl.gov seems to be having issues beyond our control: https://mcnp.discourse.group/t/nuclear-data-site-errors/2299 |
still need to do this |
I did try to address all of the grammar changes you suggested, but I suspect you got tired of noting all of them. |
tjlaboss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed my changes and ready to merge.
|
|
||
| * Redesigned how Materials hold Material_Components. See :ref:`migrate 0 1` (:pull:`507`). | ||
| * Made it easier to create an Isotope, or now Nuclide: ``montepy.Nuclide("H-1.80c")`` (:issue:`505`). | ||
| * Made it easier to create an Isotope (now Nuclide): ``montepy.Nuclide("H-1.80c")`` (:issue:`505`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever way to get the green check. I like it.
Pull Request Checklist for MontePy
Description
This is the main alpha deploy documentation update. Update tutorial and migration plan. Also adding some dev documentation.
Fixes #606, fixes #605
General Checklist
Documentation Checklist
First-Time Contributor Checklist
pyproject.tomlif you wish to do so.Additional Notes for Reviewers
Ensure that:
"""