Skip to content

Fix material to update compositions on export #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MicahGale merged 10 commits into from
Aug 13, 2024
Merged

Fix material to update compositions on export #472

MicahGale merged 10 commits into from
Aug 13, 2024

Conversation

@MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Aug 8, 2024 •
edited
Loading

Description

this fixes a bug where material composition data is not updated when written to file.
This is because the syntax tree was not being properly updated.

Fixes #470.

Checklist

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@tjlaboss tjlaboss mentioned this pull request Aug 8, 2024
Closed
@MicahGale MicahGale self-assigned this Aug 10, 2024
@MicahGale MicahGale added bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". code improvement A feature request that will improve the software and its maintainability, but be invisible to users. labels Aug 10, 2024
@MicahGale MicahGale requested a review from tjlaboss August 10, 2024 02:53
@MicahGale MicahGale marked this pull request as ready for review August 10, 2024 02:57
tjlaboss
tjlaboss approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MicahGale MicahGale merged commit a6a884f into develop Aug 13, 2024
@MicahGale MicahGale deleted the material_update branch August 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjlaboss tjlaboss tjlaboss approved these changes

Assignees

@MicahGale MicahGale

Labels

bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". code improvement A feature request that will improve the software and its maintainability, but be invisible to users.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Material always writes original material components

2 participants

@MicahGale @tjlaboss