Add warningsAreFatal parameter #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag can toggle the warnings into fatal errors and viceversa
Nicogene
force-pushed
the
addWariningsAreFatal
branch
from
443dc34
to
5584f63
Compare
|
I suggest adding a |
traversaro
reviewed
Oct 31, 2023
| @@ -143,7 +150,10 @@ void Creo2Urdf::OnCommand() { | |||
| populateExportedFrameInfoMap(component_handle); | |||
|
|
|||
| idyn_model.addLink(urdf_link_name, link); | |||
| addMeshAndExport(component_handle, link_frame_name); | |||
| if (!addMeshAndExport(component_handle, link_frame_name) && warningsAreFatal) { | |||
| printToMessageWindow("Failed to export mesh for " + link_name, c2uLogLevel::WARN); | |||
There was a problem hiding this comment.
Shouldn't we also print even if warningsAreFatal is false?
There was a problem hiding this comment.
You are right, I will make it print anyway
Nicogene
force-pushed
the
addWariningsAreFatal
branch
from
5584f63
to
12986c6
Compare
mfussi66
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag can toggle the warnings into fatal errors and viceversa