Final code changes to close #15 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 82.10% 82.14% +0.04%
==========================================
Files 117 117
Lines 32346 32385 +39
==========================================
+ Hits 26558 26603 +45
+ Misses 5788 5782 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request closes #15 and fixes a minor defect in the renaming of discontinuity sites:
import
<station-name>_yyyydoy, wheredoyis a three digit string regardless of the day of year. This pull request fixes a defect relating to naming stations when the day of year of the measurement epoch is less than 10 and/or 100. For days of the year less than 10 and/or 100, import now correctly inserts the correct number of zeros into the new discontinuity site name as per the convention. For example, the date01.01.2010is now correctly written as<station-name>_2010001(previous versions would have written this as<station-name>_20101). Note that this defect does not affect the way discontinuities are handled.adjust
--constraints "ALIC,CCC"is provided to adjust andALICis a known discontinuity site, the station and its constraint will be interpreted on the fly asALIC_yyydoy,CCC. This enables the static referencing of discontinuity sites by their primary name irrespective of new events or date changes relating to that site in the discontinuities file.All applications
stationNameOrig) has been added to the binary station file struct (see here). This affects all DynAdjust applications. The practical implication of this change for all users is that binary station files (*.bst) created by previous versions of import cannot be read by this or future versions of geoid, reftran, segment, adjust or plot, and will need to be recreated by import.