Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored D Msr directions are adjusted and not ignored. #171

Closed
nicgowans opened this issue Jan 20, 2022 · 2 comments · Fixed by #183
Closed

Ignored D Msr directions are adjusted and not ignored. #171

nicgowans opened this issue Jan 20, 2022 · 2 comments · Fixed by #183
Labels
feature improve Improve or enhance an existing feature

Comments

@nicgowans
Copy link
Contributor

Description
The ignore attribute of individual D Msr Directions has no effect when adjust.exe is run. These ignored measurements are also not counted in the import.exe ignored measurement tally (reported in *.imp file). Note: The Ignore attribute for the whole D Msr functions correctly.

DynAdjust Details

  • Version 1.2.2, Release (64-bit)
  • Build Jul 30 2021, 11:25:33 (MSVC++ 1916)

Steps to reproduce
To reproduce the behaviour:

  1. Set one or more directions within a D Msr to ignore.
  2. Run import.exe => adjust.exe (with --output-adj-msr option)
  3. Review adjusted measurements

or run DynAdjust_cmd.bat in attached sample network.
Ignored_DMsr-Dir_network.zip

Screenshots
image
image

Expected behaviour
Ignored direction exerts no influence on adjustment, column 63-65 in *.adj file indicates direction as ignored.

Operating system

  • Windows 10
@nicgowans nicgowans added the feature bug Something isn't working label Jan 20, 2022
@rogerfraser rogerfraser added feature improve Improve or enhance an existing feature and removed feature bug Something isn't working labels Jan 29, 2022
@rogerfraser
Copy link
Member

Thanks @nicgowans for raising this. In this case, we're seeing one of the limitations of the design of DynaML.xsd and, while it looks like a bug, it is expected behaviour. That is, despite the fact that DynaML.xsd permits the inclusion of an <ignore>*</ignore> element for each direction, the original intention for this element was to ignore the entire direction measurement. The same applies with GNSS baseline and point clusters (i.e. the <ignore>*</ignore> element is not meant to permit ignoring individual GNSS baselines or points from a cluster).

For these reasons, I'm inclined to change this issue from a bug to an enhancement, in the view that this feature can be added to support an obvious user requirement.

Thoughts?

@nicgowans
Copy link
Contributor Author

Thanks for this, @rogerfraser. In that case changing to an enhancement makes sense.

rogerfraser added a commit to rogerfraser/DynAdjust that referenced this issue Aug 18, 2022
This was referenced Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature improve Improve or enhance an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants