Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment crashes when all measures are ignored #150

Closed
stratiform opened this issue Jun 2, 2021 · 1 comment · Fixed by #152
Closed

Adjustment crashes when all measures are ignored #150

stratiform opened this issue Jun 2, 2021 · 1 comment · Fixed by #152
Labels
feature bug Something isn't working

Comments

@stratiform
Copy link

Description
This is a very minor bug that I am noting here for posterity rather than urgency.

Segment and adjust calls crash (i.e. exit without error code) when attempting to adjust a set of measurements which are all set to ignore = *.

Steps to reproduce
Example XML files (in txt):
msr_20210602-143853.xml.txt
stn_20210602-143855.xml.txt

import -n <name> --export-dna-files --output-msr-to-stn --reference-frame GDA2020 --output-folder <dir> stn_20210602-143855.xml msr_20210602-143853.xml 
segment <name> --input-folder <dir> --output-folder <dir> --min-inner-stns 75 --max-block-stns 75 
adjust <name> --input-folder <dir> --output-folder <dir> --output-adj-msr --output-tstat-adj-msr --sort-adj-msr-field 7 --iteration-threshold 0.0005 --max-iterations 30 --dms-msr-format 2 --precision-msr-linear 4 --precision-msr-angular 4 --output-pos-uncertainty --stn-coord-types ENzXYZ --output-database-ids --output-corrections-file --hz-corr-threshold 0.05 --vt-corr-threshold 0.0 --phased-adjustment

Expected behaviour
Segment and adjust calls should exit gracefully with a message.

Operating system

  • Windows 10
@stratiform stratiform added the feature bug Something isn't working label Jun 2, 2021
@rogerfraser
Copy link
Member

Thanks for raising this @stratiform.

As we discussed offline, this seems to relate to segment only, since running adjust in simultaneous mode has a check for this problem already, and phased adjustments cannot be executed without a *.seg file (which, of course, won't be created if segment throws an exception).

A fix has been applied and will be merged soon. A good find and thanks again.

rogerfraser added a commit that referenced this issue Jun 4, 2021
Fix #150 in segment by checking if all measurements are ignored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants