Skip to content

Copy-propagate the stack slot for collection initializers #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
siegfriedpammer merged 2 commits into from
Sep 10, 2025
Merged

Copy-propagate the stack slot for collection initializers #3554

siegfriedpammer merged 2 commits into from
Sep 10, 2025

Conversation

@ds5678
Copy link
Contributor

@ds5678 ds5678 commented Sep 8, 2025

Problem

Resolves #3552

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.
  • Which part of this PR is most in need of attention/improvement?
  • At least one test covering the code changed

ds5678 added a commit to AssetRipper/AssetRipper.Translation.LlvmIR that referenced this pull request Sep 8, 2025
@ds5678
Use duplicate instruction in constant arrays
184b707 
Related: icsharpcode/ILSpy#3554
@siegfriedpammer siegfriedpammer merged commit d1dc7b2 into icsharpcode:master Sep 10, 2025
5 checks passed
@siegfriedpammer
Copy link
Member

siegfriedpammer commented Sep 10, 2025

Thank you very much!

@ds5678 ds5678 deleted the issue3552 branch September 11, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedpammer siegfriedpammer siegfriedpammer left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dup instruction interferes with collection initialization for value types

2 participants

@ds5678 @siegfriedpammer