Allow specifying an IDecompilerTypeSystem rather than a DecompilerTypeSystem to CSharpDecompiler #3529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eSystem to CSharpDecompiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wish to provide my own custom
IDecompilerTypeSystemtoCSharpDecompiler. The existing constructorCSharpDecompiler(DecompilerTypeSystem typeSystem, DecompilerSettings settings)limits to you to specifying a value of the concreteDecompilerTypeSystemtype, however this value is assigned to thetypeSystemfield which is of typeIDecompilerTypeSystem. I did not see any restrictions that require that theIDecompilerTypeSystemthat is used must either be of typeDecompilerTypeSystemorSimpleCompilation(whichDecompilerTypeSystemderives from) so I am proposing to modify the type oftypeSystemconstructor parameter to match the type of the field that it then assigns to