-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add option to turn off smooth scrolling #3394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think PR #3403 contained the necessary NuGet update for you. |
|
|
||
| <Style TargetType="ScrollViewer"> | ||
| <Setter Property="toms:AdvancedScrollWheelBehavior.Attach" Value="WithAnimation" /> | ||
| <Style.Triggers> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As written in the documentation, Attach is a shortcut and should only be used if you want to go with the default only.
If you want to control the behavior, you should not attach and detach it, but use the full behavior notation and simply configure the properties of interest. (now I understand the intend of tom-englert/TomsToolbox#20, this was not necessary at all)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not aware of the method you used in your implementation, hence this rudimentary implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree this is a bit hidden, in xaml VS does not show the documentation directly when hovering...
|
I'd say to go with #3405 instead of this since it's already fixed and Tom seems to know more about this than I do. I'm just glad there will be an option to turn off smooth scrolling. :) |
Fixes #3393
Problem
Smooth scrolling was recently added and not everyone enjoys that.
Solution
Add an option to toggle smooth scrolling. I added it under Display -> Other options

The option applies to everywhere ScrollViewer is used and ZoomScrollView, which seems to just be the options dialog and the main text editor.
This PR is currently blocked due to needing a bug fix in TomsToolbox tom-englert/TomsToolbox#20, hence the draft