Migrate to NUnit 4 #3132
Merged
Migrate to NUnit 4 #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -486,7 +486,7 @@ async Task RunIL(string testFileName, CompilerOptions options = CompilerOptions. | |||
| bool optionsForce32Bit = options.HasFlag(CompilerOptions.Force32Bit); | |||
| bool asmOptionsForce32Bit = asmOptions.HasFlag(AssemblerOptions.Force32Bit); | |||
|
|
|||
| Assert.AreEqual(optionsForce32Bit, asmOptionsForce32Bit, "Inconsistent architecture."); | |||
| Assert.That(asmOptionsForce32Bit, Is.EqualTo(optionsForce32Bit), "Inconsistent architecture."); | |||
There was a problem hiding this comment.
I really don't like that overly verbose syntax.... what's wrong with AreEqual?
There was a problem hiding this comment.
https://docs.nunit.org/articles/nunit/writing-tests/assertions/assertions.html... why not keep the classic model for all the existing tests?
There was a problem hiding this comment.
Guess what will happen if we keep classic. It will be copy pasted forever.
There was a problem hiding this comment.
I see no problem with that... :D the short forms are more intuitive...
|
Version 4.0.1 is out on nuget, https://docs.nunit.org/articles/nunit/release-notes/framework.html#nunit-401---december-2-2023 |
mattsh247
pushed a commit
to mattsh247/ILSpy
that referenced
this pull request
Jul 30, 2024
* Migrate to NUnit 4 based on https://docs.nunit.org/articles/nunit/release-notes/Nunit4.0-MigrationGuide.html. Needed fix for nunit/nunit#4564 * Test 4.1.0-adev.1 from NUnit MyGet feed (works locally in VS) * Update to bugfix version adev.2 (works on GH) * NUnit 4.0.1 final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using a preview of NUnit from MyGet. Will be replaced with nuget.org again once bug fix release is published.