Fix decompilation of record with missing base type #3021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in #3020, the decompiler fails with a NullReferenceException when attempting to decompile a record type whose base type cannot be determined (e.g. because the base type is defined in another assembly that is not loaded).
Solution
This commit updates
RecordDecompiler
to null check thebaseClass
field before making use of it. With this fix, the null ref is avoided, but the generated code for the record will contain unnecessary[CompilerGenerated]
members: