Include property and event return types in RequiredNamespaceCollector
#2843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this covers:
#2842
Problem
The
ZennoLab.Structures.Properties.Resources
class contained a property that had it's return type set toSystem.Globalization.CultureInfo
but the accessor parameters usedSystem.Object
. This caused theRequiredNamespaceCollector
not to detect theSystem.Globalization
namespace. This led to the assertion mentioned in the issue.Solution
Include return types of properties and events in the analysis done by
RequiredNamespaceCollector
.fixes #2842