Include assembly name in decompiled code #2810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When exploring decompiled methods and other members and jumping all around through analysis tree, inheritance etc., it is difficult to figure out to which assembly the currently displayed code belongs. On has to scroll the treeview to an exact narrow position, or just keep collapsing it manually.
Solution
The proposed solution is to include the assembly name as a comment above the existing comment containing full type name.
Another approach would be to include it with the type comment in
CSharpAmbience.ConvertSymbol
, possibly usingConversionFlags.UseAssemblyName
, but that seemed unnecessarily complex.Namespaces do not show assembly because it is not readily available around.
This does not come with tests, happy to add some if deemed necessary and given some pointers whereabouts are similar tests e.g. for the type comment.
assembly
cannot be null becauseCreateDecompiler
already dereferences it.