Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't browse assembly resources #2759

Closed
greenozon opened this issue Jul 30, 2022 · 3 comments
Closed

Can't browse assembly resources #2759

greenozon opened this issue Jul 30, 2022 · 3 comments
Labels
Bug

Comments

@greenozon
Copy link

greenozon commented Jul 30, 2022 •
edited
Loading

Steps to reproduce

  1. Just try to expand resources of the assembly

Error message shown

image

Details

  • Product in use: e.g. ILSpy / ICSharpCode.Decompiler nuget package / VS extension
    ILSpy version 8.0.0.7106-preview2
    .NET version 6.0.7-servicing.22322.2+0ec02c8c96e2eda06dc5b5edfdbdba0f36415082

https://www.sendspace.com/file/tw53w2

Proposal

Do not allow multi-line text in References as well as Resources
eg how it is handled by dnSpy:
image
@greenozon greenozon added the Bug label Jul 30, 2022
@greenozon
Copy link
Author

Pardon leaving comment on closed issue, but there is still one question left: the References entry seems looking weired in ILSpy comparing to dnSpy:

image

any chance to make it single line in ILSpy please?

@greenozon
Copy link
Author

And another, more serious issue - for some reason you can't open References tree node by Mouse double click, ony by keyboard

  • sometimes ILSpy hangs using much CPU cycles...

siegfriedpammer added a commit that referenced this issue Aug 26, 2022
@siegfriedpammer
Addendum to #2759: Escape names of references as well.
d1afa58
@greenozon
Copy link
Author

Thanks! now it is all set and working as expected
kudos!

hexafluoride pushed a commit to hexafluoride/ILSpy that referenced this issue Aug 31, 2022
@siegfriedpammer @hexafluoride
Fix icsharpcode#2759: Some characters cause rendering issues in the t…
6d97ef2 
…ree view causing ILSpy to freeze. Also ignore embedded resources with an invalid offset, treat them as having zero byte length.
hexafluoride pushed a commit to hexafluoride/ILSpy that referenced this issue Aug 31, 2022
@siegfriedpammer @hexafluoride
Addendum to icsharpcode#2759: Escape names of references as well.
6898394
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greenozon