Enable arm64 vsix #990
Merged
Enable arm64 vsix #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have an ARM device - do we have a sort-of go-to standard test project for testing conversion? |
|
Just tried on Windows on Arm in Parallels VM on Apple Silicon, works with no problems |
|
@christophwille You could use the solution that the automated tests convert. https://github.com/icsharpcode/CodeConverter/tree/master/Tests/TestData/MultiFileCharacterization/SourceFiles |
|
Yes, running the tests on arm64 would be useful. |
|
Gave it a spin on 17.5.2 on Surface X Windows 11 Moment 2 (latest everything basically) - works. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #989
This should make the extension installable on VS2022 on arm. I don't have a device to test it with, and even if it installs it may not work. Any feedback would be appreciated
ICSharpCode.CodeConverter.VsExtension.zip