Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the events from syntax that have been optimized away #530

Merged
merged 4 commits into from
Feb 29, 2020
+127 −28
Merged

Get the events from syntax that have been optimized away #530

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4364b8
Get the events from syntax that have been optimized away
GrahamTheCoder Feb 19, 2020
ce22594
Don't map trivia for moved id
GrahamTheCoder Feb 29, 2020
0be864e
Characterize current behaviour
GrahamTheCoder Feb 29, 2020
674f3f8
This now appears in the right place
GrahamTheCoder Feb 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
This now appears in the right place
  • Loading branch information
@GrahamTheCoder
GrahamTheCoder committed Feb 29, 2020
commit 674f3f8c93812b46280f29a544863ceabbff799f
4 changes: 2 additions & 2 deletions Tests/CSharp/NamespaceLevelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ public partial interface Foo
public async Task MyClassVirtualCallMethod()
{
await TestConversionVisualBasicToCSharp(@"Public Class A
Overridable Function F1() As Integer ' Becomes delegating method
Overridable Function F1() As Integer
Return 1
End Function
MustOverride Function F2() As Integer
Expand All @@ -871,7 +871,7 @@ public int MyClassF1()
return 1;
}

public virtual int F1() => MyClassF1(); // Becomes delegating method
public virtual int F1() => MyClassF1();
public abstract int F2();

public void TestMethod()
Expand Down