Starting point for others: Convert MsgBox to MessageBox.Show #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a conversion from `Microsoft.VisualBasic.Interaction.MsgBox` to `System.Windows.Forms.MessageBox.Show`. I handled the mapping of `MsgBoxStyle` to `MessageBoxButtons` and `MessageBoxIcon`, and reordered the arguments appropriately. The type mapping from `MsgBoxResult` to `DialogResult` is not yet implemented. Fixes icsharpcode#1166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is generated with a coding agent, but I've skimmed the code to ensure it's roughly the right shape in the right place. If someone's keen to bring this functionality to the system it should be a great starting point (just checkout the branch, try it out, add any more tests/improvements needed).
Note: I'm not intending to work on this further myself at this time, it's just an example to help new contributors.
Agent comments
This change introduces a conversion from
Microsoft.VisualBasic.Interaction.MsgBoxtoSystem.Windows.Forms.MessageBox.Show.I handled the mapping of
MsgBoxStyletoMessageBoxButtonsandMessageBoxIcon, and reordered the arguments appropriately.The type mapping from
MsgBoxResulttoDialogResultis not yet implemented.Problem
Fixes #1166
Solution