Skip to content

Refactors test suite to run with vanilla PHPUnit runner #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garethellis36 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Refactors test suite to run with vanilla PHPUnit runner #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a971103
Refactors test suite to run with vanilla PHPUnit runner
Feb 11, 2021
c39aa50
Self-review changes
Feb 11, 2021
fc3a4de
Don't stop on failure
Feb 12, 2021
dece43f
Updating comments
Feb 12, 2021
68ef743
README update
Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ This repository is not intended to be used by developers from outside our team a
- Updated PHPUnit to version 6
- Updated PHPUnit to version 7
- Removed ability to run app/plugin tests with Cake's test shell
- Updated the core test suite so that it can be run using PHPUnit's standard test runner and doesn't require Cake's test shell

# Roadmap
- Update the core test suite so that it can be run using PHPUnit's standard test runner and doesn't require Cake's test shell. Some sticking points in updating PHPUnit have come about because of the unique way Cake's tests are run

- Update PHPUnit to version 8
- Update PHPUnit to version 9
- Execute framework tests on PHP 7.4
Expand All @@ -30,13 +31,13 @@ There are currently `4035` tests in the suite. This is useful to know when upgra
SQLite:
```
OK, but incomplete, skipped, or risky tests!
Tests: 4035, Assertions: 20487, Skipped: 319.
Tests: 4028, Assertions: 20383, Skipped: 320.
```

MYSQL:
```
OK, but incomplete, skipped, or risky tests!
Tests: 4035, Assertions: 20157, Skipped: 192.
Tests: 4028, Assertions: 21228, Skipped: 193.
```

Run the tests in a CentOS VM. You will need the following in addition to our basic PHP set-up.
Expand All @@ -48,12 +49,8 @@ sudo localedef -v -c -i de_DE -f UTF-8 de_DE
```

Running tests:
`./tests AllTests`

To run a single test, you need to use the "Cake namespace" of the class under test. e.g. to run `lib/Cake/Model/Datasource/CakeSessionTest`, you would run:

`./tests Model/Datasource/CakeSession`
`vendors/bin/phpunit`

By default, the tests run with an sqlite database, to run for MySQL, you need to configure a database connection in `app/Config/database.php` and make sure the following empty databases have been created:
`cakephp_test`, `cakephp_test2`, `cakephp_test3`, and then set the env var `DB` to `mysql`, i.e.:
`DB=mysql ./tests AllTests`
`DB=mysql vendors/bin/phpunit`
6 changes: 0 additions & 6 deletions tests → fixturize_tmp_dir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,3 @@ mkdir -p /home/vagrant/caketmp/sessions
find /home/vagrant/caketmp/ -type f -delete
chmod -R 777 /home/vagrant/caketmp
rm -rf /home/vagrant/caketmp/tests
DB="${DB:-sqlite}" php \
-d memory_limit=512M \
-d auto_prepend_file=test_bootstrap.php \
./lib/Cake/Console/cake.php test core \
$* \
--stderr --globals-backup
Loading