Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python to 3.12 and upgrade workflow runner #712

Merged

Conversation

harryzcy
Copy link
Contributor

@harryzcy harryzcy commented Nov 8, 2023

No description provided.

@harryzcy
Copy link
Contributor Author

harryzcy commented Nov 9, 2023

The failing test is related to PythonCharmers/python-future#625. It's only imported once, we can easily remove it.

@AndreyNikiforov
Copy link
Collaborator

The failing test is related to PythonCharmers/python-future#625. It's only imported once, we can easily remove it.

You can run test locally. If you are using dev container, then switching python versions should be easy and you can validate tests in all supported python versions -- that will be faster than waiting for github actions approved.

@harryzcy harryzcy changed the title Upgrade docker images and add dependabot rules Upgrade python to 3.12 Nov 9, 2023
@harryzcy harryzcy changed the title Upgrade python to 3.12 Upgrade python to 3.12 and upgrade workflow runner Nov 9, 2023
@harryzcy
Copy link
Contributor Author

@AndreyNikiforov Hi, can you help to review this again?

@AndreyNikiforov AndreyNikiforov merged commit 4bf4f5e into icloud-photos-downloader:master Nov 21, 2023
26 checks passed
@harryzcy harryzcy deleted the docker-dependency branch November 21, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants