Upgrade python to 3.12 and upgrade workflow runner #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test is related to PythonCharmers/python-future#625. It's only imported once, we can easily remove it. |
You can run test locally. If you are using dev container, then switching python versions should be easy and you can validate tests in all supported python versions -- that will be faster than waiting for github actions approved. |
harryzcy
changed the title
harryzcy
changed the title
|
@AndreyNikiforov Hi, can you help to review this again? |
AndreyNikiforov
merged commit 4bf4f5e
into
icloud-photos-downloader:master
26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.