Verify OTP without marking it as used. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichtrojan
reviewed
Dec 22, 2024
src/Otp.php
Outdated
Comment on lines
56
to
65
| if($otp){ | ||
| $now = Carbon::now(); | ||
| $validity = $otp->created_at->addMinutes($otp->validity); | ||
|
|
||
| if( $otp->valid && (strtotime($validity) >= strtotime($now))) { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
if ($otp instanceof Model) {
$validity = $otp->created_at->addMinutes($otp->validity);
return Carbon::now()->lt($validity);
}
return false; There was a problem hiding this comment.
Thank you for the suggestion. I have added a condition to check the "valid" property in the model, as it could still be invalid even if Carbon::now()->lt($validity); returns true.
ichtrojan
reviewed
Dec 22, 2024
ichtrojan
reviewed
Dec 22, 2024
ichtrojan
reviewed
Dec 22, 2024
ichtrojan
reviewed
Dec 22, 2024
ichtrojan
reviewed
Dec 23, 2024
ichtrojan
reviewed
Dec 23, 2024
ichtrojan
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some application may only need to check the validity of the OTP before using it, so, this pull request introduces a new method isValid to the Otp class. The isValid method checks the existence and validity of an OTP (the same way you use) without marking it as used.
Benefits
Usage