[Fix] Image atlas cannot be grown past multiples of 6 on wgpu GL backend #3016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungoboingo
force-pushed
the
hack/gles-fix-part2
branch
from
2127ea3 to
54f9fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original "fix" just hard checked if layers.len() == 6 before to solve an issue where a user had exactly 6 atlas layers, but actually the
GL_TEXTURE_CUBE_ARRAYcheck in wgpu is% 6. A different user recently had 12 atlas layers and was still encountering the original issue. I've confirmed this fix solved his issue.This hack should "fix" this for real until wgpu updates their method of checking texture types for GL backends.
https://github.com/gfx-rs/wgpu/blob/5b2c8406bf787f8b8f86ece1f0b0ba67e72874d2/wgpu-hal/src/lib.rs#L1901
This is the link to the actual check in wgpu, for reference.