-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background styling to span / rich text #2516
Conversation
1feb29a
to
f70edc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could improve the creation of the text::Background
with a few helpers, and also possibly changing it to span::Background
.
But looks pretty good overall!
f70edc2
to
4dc7b9b
Compare
f257b0b
to
2796a6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simplified some stuff here and there, but looks great! 🥳
Adds a new
text::Background
type which can be optionally specified onSpan
.rich_text
will use this to render background quads for spans where this is set.A new
Paragraph::span_bounds
method is added to get the bounds of each span to enabled this.simplescreenrecorder-2024-07-23_13.37.52.mp4
I'm using this in Halloy: