Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block_on in iced_wgpu hanging Wasm builds #2313

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Mar 7, 2024

This PR removes a block_on use in iced_wgpu by making Compositor::new async and running the whole event loop inside an executor.

As a result, Wasm builds no longer freeze the whole tab.

@hecrj hecrj added bug Something isn't working web fix labels Mar 7, 2024
@hecrj hecrj modified the milestones: 0.12.3, 0.13 Mar 7, 2024
@hecrj hecrj enabled auto-merge March 7, 2024 22:30
@hecrj hecrj merged commit 2074757 into master Mar 7, 2024
24 checks passed
@hecrj hecrj deleted the fix/wasm-block-on branch March 7, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant