Conversation
|
Posting here for visibility: This also fixes the reentrant mutex issue I reported a while ago. However, after switching to this commit, requesting redraw/redrawing an image constantly makes the window redraw really slow. It's slower the bigger the window is. The Iced debug overlay doesn't show increased times when the issue happens so it's likely something outside of iced rendering. Edit: |
|
I believe it's some sort of scheduling issue. There are no outliers in the flamegraph which corresponds with iced's debug overlay not having increased times. Even the spinner example gets choppy sometimes now on the winit branch and it doesn't on the latest master. |
|
Yeah please do this gets the window shadow drawn |
|
No, in sctk-adwaita at v0.8.0 has shadows. |
|
|
Nevermind that, I forgot that iced is using a fork of winit (that does not use 0.8 yet): https://github.com/iced-rs/winit/blob/3bcdb9abcd7459978ec689523bc21943d38da0f9/Cargo.toml#L163 |

This PR updates our
winitfork with the latest changes in0.29.Fixes #2113.
Fixes #2138.