feat: add support to ARM devices (and older hardware) #1160
Conversation
derezzedex
force-pushed
the
dev/arm-support
branch
from
b4b4cb4
to
d5bb93d
Compare
There was a problem hiding this comment.
Looks great! Really nice job here 🥳
In the future, once offscreen rendering lands, it'd be great to test the output of both pipelines (potentially in CI) to ensure minimal differences!
In any case, I left just a couple of suggestions! Let me know what you think.
docker/README.md
Outdated
| ### Raspberry Pi 3/4 (64 bits) | ||
| ``` | ||
| $ docker build -t iced-rs/aarch64 -f Dockerfile.aarch64-unknown-linux-gnu . | ||
| ``` |
There was a problem hiding this comment.
I think this docker folder is generic enough to become a standalone repository for all of the Rust ecosystem!
Instead of including it here, I believe we could create a GitHub Action to easily cross-compile any Rust project for Raspberry Pis. I'll gladly help you out with this!
Once we do that, we could then change the build workflow to additionally build binaries of the todos example for the Raspberry Pis and make sure we keep everything compatible moving forward.
There was a problem hiding this comment.
Right now the Dockerfiles are tailored to iced, but if we wanted we could upload the images to 'Docker Hub'.
This could be useful to developers cross-compiling their iced apps, meaning they could build using our Dockerfile:
FROM iced-rs/iced:arm64There was a problem hiding this comment.
I like the idea! I have created an organization in Docker Hub and a new iced-rs/docker repository.
Let me know your username in Docker Hub and I will add you.
There was a problem hiding this comment.
I have added a workflow in iced-rs/docker to build the images in GitHub CI and push them to Docker Hub.
Also, I have removed the docker folder in 33d52b5 and added a todos_raspberry job to the build workflow in 522368e. Everything seems to work nicely!
It'd be great if you could try the binaries from this GitHub CI run in the Pis.
hecrj
force-pushed
the
master
branch
2 times, most recently
from
e6ab610
to
8b0f2e6
Compare
to simplify and constrain `program::create`
derezzedex
force-pushed
the
dev/arm-support
branch
from
d5bb93d
to
424e1d3
Compare
hecrj
force-pushed
the
dev/arm-support
branch
from
dd90cef
to
55cba5e
Compare
hecrj
force-pushed
the
dev/arm-support
branch
from
55cba5e
to
522368e
Compare
This PR aims to add support to ARM devices and older hardware.
Since this depends on hecrj/glow_glyph#5, the main idea of those changes are basically the same, so check that first.
Changes
To maximize compatibility, this PR does a couple of things:
armv7andaarch64.quadpipeline intocoreandcompatibility.Settingfield to allow developers to try OpenGL ES first (this should be better for embedded devices).There are also some "quality of life" changes:
env_loggertogame_of_life).iced_winit::conversioniniced_glutin.glowandwiniton theiriced_version.Fixes a problem with the(Fix memory leak in opengl integration example #1181)integration_openglexample.Closes #428.
Closes #931.