-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
tech debt cleanupWe need to do this to avoid tech debtWe need to do this to avoid tech debt
Description
The following arguments of start_scan:
input_time_name: strinput_pos_name: stroutput_particle_name: str
define the starting seed (fallback_*) and the current seedoutput_particle_name.
These arguments are never used and they always correspond to default values.
What reco modules do now is write the starting seed to the default value of input_(pos|time)_name (server-side) which is cfg.INPUT_(POS|TIME)_NAME and read the current seed from the default value of output_particle_name (client-side) which is cfg.OUTPUT_PARTICLE_NAME.
In other words, there is no benefit in defining any of this in start_scan. The reco module could provide a name for the starting seed (optionally, more than one) while output_particle_name is purely conventional.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
tech debt cleanupWe need to do this to avoid tech debtWe need to do this to avoid tech debt