Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for opensuse #25

Merged
merged 5 commits into from
Jan 6, 2013
Merged

fixes for opensuse #25

merged 5 commits into from
Jan 6, 2013

Conversation

llunak
Copy link
Contributor

@llunak llunak commented Jan 5, 2013

The changes to use cap-ng and not run as root have broken icecream on suse (and not only, I'd say) in a number of ways - log file can no longer be written to /var/log, env. cache directory can no longer be completely removed if in /var/cache/icecream, user is mixed to be 'icecream' or 'icecc', and chown() fails. I think I've fixed all of these and it seems to work fine now, but as this is security relatd stuff, I'd like a review before this goes in.

Luboš Luňák added 5 commits January 5, 2013 13:50
After the switch to make the daemon run as non-root user, it has no rights
to do anything in /var/log . These suse-specific changes were missed
in the commit that did the changes.
Since the change to run as non-root, the daemon cannot remove e.g.
/var/cache/icecream because of no rights to modify /var/cache.
The daemon no longer runs as root.
@llunak llunak closed this Jan 5, 2013
@llunak llunak reopened this Jan 5, 2013
@ghost ghost assigned coolo Jan 5, 2013
@llunak
Copy link
Contributor Author

llunak commented Jan 5, 2013

BTW, the openSUSE package will also need .spec file update, the one generated here in suse/ should do.

@coolo
Copy link
Contributor

coolo commented Jan 6, 2013

I was fine with renaming the user to icecc, but consistency might be an advantage

coolo added a commit that referenced this pull request Jan 6, 2013
@coolo coolo merged commit 5958bad into icecc:master Jan 6, 2013
@llunak
Copy link
Contributor Author

llunak commented Jan 6, 2013

I'm too lazy to check to be sure, now that the user is back to 'icecream', but I think using 'icecc' (i.e. a new user) caused upgrade problems - with the daemon no longer being root, it would have trouble cleaning up /var/cache/icecream entries from the previous version.

@llunak
Copy link
Contributor Author

llunak commented Jan 6, 2013

Actually I'm afraid there may upgrade problems anyway :(. I have a machine where /var/cache/icecream/target=x86_64 is owned by root:root . I do not see any other solution than extra cleaning up while still having root privileges, I'll push the change.

@coolo
Copy link
Contributor

coolo commented Jan 6, 2013

It may just be fair to clean those directories when the rpm is updated

llunak notifications@github.com schrieb:

Actually I'm afraid there may upgrade problems anyway :(. I have a
machine where /var/cache/icecream/target=x86_64 is owned by root:root .
I do not see any other solution than extra cleaning up while still
having root privileges, I'll push the change.


Reply to this email directly or view it on GitHub:
#25 (comment)

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

@llunak
Copy link
Contributor Author

llunak commented Jan 6, 2013

Makes sense, I'll change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants